github-vet / github-vet/rangeloop-pointer-findings
wonderix/shalm: pkg/extensions/osb_binding.go; 10 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [wonderix/shalm](https://www.github.com/wonderix/shalm) at [pkg/extensions/osb_binding.go](https://github.com/wonderix/shalm/blob/c6e5cb6f5267d8125fde0fd318393185dd1ab259/pkg/extensions/osb_binding.go#L120-L129)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.
> reference to service is reassigned at line 122
[Click here to see the code in its original context.](https://github.com/wonderix/shalm/blob/c6e5cb6f5267d8125fde0fd318393185dd1ab259/pkg/extensions/osb_binding.go#L120-L129)
Click here to show the 10 line(s) of Go which triggered the analyzer.
```go
for _, service := range catalog.Services {
if service.Name == v.service {
selectedService = &service
for _, plan := range service.Plans {
if plan.Name == v.plan {
selectedPlan = &plan
}
}
}
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: c6e5cb6f5267d8125fde0fd318393185dd1ab259
Contributor guide
No contributing guide indexed for this repository
Research direction
Review pkg/extensions/osb_binding.go around lines 120-129 and the analyzer message about the service reference being reassigned. Check the surrounding context to decide whether this is a Bug, Mitigated, or Desirable Behavior, then leave the corresponding reaction on the issue.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100