hashicorp/vault: builtin/logical/aws/iam_policies.go; 36 LoC

Found a possible issue in [hashicorp/vault](https://www.github.com/hashicorp/vault) at [builtin/logical/aws/iam_policies.go](https://github.com/hashicorp/vault/blob/f2cf40ce1ff8377d053009ebae6b0dab3e1b00a8/builtin/logical/aws/iam_policies.go#L71-L106)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to g was used in a composite literal at line 92

[Click here to see the code in its original context.](https://github.com/hashicorp/vault/blob/f2cf40ce1ff8377d053009ebae6b0dab3e1b00a8/builtin/logical/aws/iam_policies.go#L71-L106)

Click here to show the 36 line(s) of Go which triggered the analyzer.

```go
for _, g := range iamGroups {
// Collect managed policy ARNs from the IAM Group
agp, err = iamClient.ListAttachedGroupPolicies(&iam.ListAttachedGroupPoliciesInput{
GroupName: aws.String(g),
})
if err != nil {
return nil, nil, err
}
for _, p := range agp.AttachedPolicies {
groupPolicyARNs = append(groupPolicyARNs, *p.PolicyArn)
}

// Collect inline policy names from the IAM Group
inlinePolicies, err = iamClient.ListGroupPolicies(&iam.ListGroupPoliciesInput{
GroupName: aws.String(g),
})
if err != nil {
return nil, nil, err
}
for _, iP := range inlinePolicies.PolicyNames {
inlinePolicyDoc, err = iamClient.GetGroupPolicy(&iam.GetGroupPolicyInput{
GroupName: &g,
PolicyName: iP,
})
if err != nil {
return nil, nil, err
}
if inlinePolicyDoc != nil && inlinePolicyDoc.PolicyDocument != nil {
var policyStr string
if policyStr, err = url.QueryUnescape(*inlinePolicyDoc.PolicyDocument); err != nil {
return nil, nil, err
}
groupPolicies = append(groupPolicies, policyStr)
}
}
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: f2cf40ce1ff8377d053009ebae6b0dab3e1b00a8