MarkZuber/msalgo: internal/requests/AadInstanceDiscovery.go; 6 LoC

Found a possible issue in [MarkZuber/msalgo](https://www.github.com/MarkZuber/msalgo) at [internal/requests/AadInstanceDiscovery.go](https://github.com/MarkZuber/msalgo/blob/9545aa61792fd9078e77395d3366420fb72b88a7/internal/requests/AadInstanceDiscovery.go#L35-L40)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to metadataEntry is reassigned at line 38

[Click here to see the code in its original context.](https://github.com/MarkZuber/msalgo/blob/9545aa61792fd9078e77395d3366420fb72b88a7/internal/requests/AadInstanceDiscovery.go#L35-L40)

Click here to show the 6 line(s) of Go which triggered the analyzer.

```go
for _, metadataEntry := range discoveryResponse.Metadata {
metadataEntry.TenantDiscoveryEndpoint = discoveryResponse.TenantDiscoveryEndpoint
for _, aliasedAuthority := range metadataEntry.Aliases {
instanceDiscoveryCache[aliasedAuthority] = &metadataEntry
}
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 9545aa61792fd9078e77395d3366420fb72b88a7

Read internal/requests/AadInstanceDiscovery.go around lines 35-40 and inspect how discoveryResponse.Metadata and instanceDiscoveryCache are used. Determine whether taking the address of the range variable causes incorrect cached entries, then classify the analyzer finding as Bug, Mitigated, or Desirable Behavior using the linked guidance.

Written by the indexing model from the issue text.