github-vet / github-vet/rangeloop-pointer-findings
joeandaverde/tinydb: internal/storage/storage.go; 6 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [joeandaverde/tinydb](https://www.github.com/joeandaverde/tinydb) at [internal/storage/storage.go](https://github.com/joeandaverde/tinydb/blob/0a6a5a745e407b9976452e4d544e2a2166b506f1/internal/storage/storage.go#L58-L63)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.
> reference to record was used in a composite literal at line 61
[Click here to see the code in its original context.](https://github.com/joeandaverde/tinydb/blob/0a6a5a745e407b9976452e4d544e2a2166b506f1/internal/storage/storage.go#L58-L63)
Click here to show the 6 line(s) of Go which triggered the analyzer.
```go
for record := range rowChan {
bt.Insert(&btree.StringItem{
Key: record.Fields[1].Data.(string),
Data: &record,
})
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: 0a6a5a745e407b9976452e4d544e2a2166b506f1
Contributor guide
No contributing guide indexed for this repository
Research direction
Inspect internal/storage/storage.go at lines 58-63 and review the analyzer message about the reference used in the composite literal. Compare the reported behavior with the linked Go code, then classify the finding by leaving the appropriate reaction: Bug, Mitigated, or Desirable Behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- databases
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100