github-vet / github-vet/rangeloop-pointer-findings

HouzuoGuo/laitos: misc/program_control.go; 14 LoC

Open
#12,779 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [HouzuoGuo/laitos](https://www.github.com/HouzuoGuo/laitos) at [misc/program_control.go](https://github.com/HouzuoGuo/laitos/blob/12268223cd2341ceb99cdcee3fadfb81dd6c3f57/misc/program_control.go#L101-L114)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> range-loop variable dirToKill used in defer or goroutine at line 106

[Click here to see the code in its original context.](https://github.com/HouzuoGuo/laitos/blob/12268223cd2341ceb99cdcee3fadfb81dd6c3f57/misc/program_control.go#L101-L114)

Click here to show the 14 line(s) of Go which triggered the analyzer.

```go
for _, dirToKill := range dirsToKill {
// Destroy directories in parallel
go func() {
// Ignore but log failure and keep going
for {
logger.Info("TriggerEmergencyKill", "", nil, "attempt to destroy directory - %s", dirToKill)
err := os.RemoveAll(dirToKill)
logger.Info("TriggerEmergencyKill", "", err, "finished attempt at destroying directory - %s", dirToKill)
// Avoid overwhelming disk or CPU due to the deliberately infinite loop
time.Sleep(1 * time.Second)
}
}()
time.Sleep(200 * time.Millisecond)
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 12268223cd2341ceb99cdcee3fadfb81dd6c3f57

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.