xaiki/zif: libzif/localpeerhandlers.go; 45 LoC

Found a possible issue in [xaiki/zif](https://www.github.com/xaiki/zif) at [libzif/localpeerhandlers.go](https://github.com/xaiki/zif/blob/204028b131e2abb55ebbde4555bdb734a9f84481/libzif/localpeerhandlers.go#L165-L209)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> range-loop variable i used in defer or goroutine at line 167

[Click here to see the code in its original context.](https://github.com/xaiki/zif/blob/204028b131e2abb55ebbde4555bdb734a9f84481/libzif/localpeerhandlers.go#L165-L209)

Click here to show the 45 line(s) of Go which triggered the analyzer.

```go
for _, i := range closest {
go func() {
if i.Key.Equals(&entry.Address) || i.Key.Equals(msg.From) {
return
}

peer := lp.GetPeer(entry.Address.String())

if peer == nil {
log.Debug("Connecting to new peer")

decoded, err := JsonToEntry(i.Value)

if err != nil {
return
}

var p Peer
err = p.Connect(decoded.PublicAddress+":"+strconv.Itoa(decoded.Port), lp)

if err != nil {
log.Warn("Failed to connect to peer: ", err.Error())
return
}

p.ConnectClient(lp)

peer = &p
}

peer_stream, err := peer.OpenStream()
defer peer_stream.Close()

if err != nil {
log.Error(err.Error())
return
}

peer_announce := &proto.Message{
Header: proto.ProtoDhtAnnounce,
Content: msg.Content,
}
peer_stream.WriteMessage(peer_announce)
}()
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 204028b131e2abb55ebbde4555bdb734a9f84481

Read libzif/localpeerhandlers.go lines 165-209 at commit 204028b131e2abb55ebbde4555bdb734a9f84481, starting with the reported range-loop variable capture in the goroutine and the surrounding peer connection flow. Determine whether the analyzer finding represents a bug, mitigation, or desirable behavior, then leave the corresponding reaction on the issue.

Written by the indexing model from the issue text.