TRON-US/go-btfs: core/commands/swarm.go; 24 LoC

Found a possible issue in [TRON-US/go-btfs](https://www.github.com/TRON-US/go-btfs) at [core/commands/swarm.go](https://github.com/TRON-US/go-btfs/blob/bf18415cf63962bb94168971c262af41e95d7a57/core/commands/swarm.go#L421-L444)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to ainfo was used in a composite literal at line 422

[Click here to see the code in its original context.](https://github.com/TRON-US/go-btfs/blob/bf18415cf63962bb94168971c262af41e95d7a57/core/commands/swarm.go#L421-L444)

Click here to show the 24 line(s) of Go which triggered the analyzer.

```go
for _, ainfo := range addrs {
maddrs, err := peer.AddrInfoToP2pAddrs(&ainfo)
if err != nil {
return err
}
// FIXME: This will print:
//
// disconnect QmFoo success
// disconnect QmFoo success
// ...
//
// Once per address specified. However, I'm not sure of
// a good backwards compat solution. Right now, I'm just
// preserving the current behavior.
for _, addr := range maddrs {
msg := "disconnect " + ainfo.ID.Pretty()
if err := api.Swarm().Disconnect(req.Context, addr); err != nil {
msg += " failure: " + err.Error()
} else {
msg += " success"
}
output = append(output, msg)
}
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: bf18415cf63962bb94168971c262af41e95d7a57

Read core/commands/swarm.go around lines 421-444, focusing on the range loop and the &ainfo passed to AddrInfoToP2pAddrs. Check whether the reported pointer-to-range-variable behavior affects this command and whether the current behavior is intentional; done means leaving the requested Bug, Mitigated, or Desirable Behavior classification with evidence.

Written by the indexing model from the issue text.