github-vet / github-vet/rangeloop-pointer-findings

archichris/multus-ext-cni: multus-ipam/backend/etcdv3cli/cli.go; 18 LoC

Open
#12,736 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [archichris/multus-ext-cni](https://www.github.com/archichris/multus-ext-cni) at [multus-ipam/backend/etcdv3cli/cli.go](https://github.com/archichris/multus-ext-cni/blob/aa8d8a725fe9220dd067f8359bbeeddaff06c08b/multus-ipam/backend/etcdv3cli/cli.go#L199-L216)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to csr is reassigned at line 204

[Click here to see the code in its original context.](https://github.com/archichris/multus-ext-cni/blob/aa8d8a725fe9220dd067f8359bbeeddaff06c08b/multus-ipam/backend/etcdv3cli/cli.go#L199-L216)

Click here to show the 18 line(s) of Go which triggered the analyzer.

```go
for _, csr := range caches {
last = nil
var lsr allocator.SimpleRange
for _, lsr = range leases {
if csr.Match(&lsr) {
last = &csr
break
}
}
logging.Debugf("cache:%v, lease:%v, result:%v", csr, lsr, last)
if last == nil {
err = etcdv3.TransPutKey(cli, ipamSimpleRangeToLease(keyDir, &csr), id, true)
if err != nil {
logging.Debugf("going to delete error cache:%v", csr)
s.DeleteCache(&csr)
}
}
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: aa8d8a725fe9220dd067f8359bbeeddaff06c08b

Contributor guide

No contributing guide indexed for this repository

Research direction

Review multus-ipam/backend/etcdv3cli/cli.go around lines 199-216, then inspect the surrounding cache and lease handling to understand whether the referenced range-loop variable can produce incorrect behavior. Compare the analyzer finding with the project’s classification guidance and determine whether the instance is a bug, mitigated, or desirable behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.