github-vet / github-vet/rangeloop-pointer-findings
phoebus101/ttnstack: cmd/ttn-lw-cli/commands/end_device_templates.go; 13 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [phoebus101/ttnstack](https://www.github.com/phoebus101/ttnstack) at [cmd/ttn-lw-cli/commands/end_device_templates.go](https://github.com/phoebus101/ttnstack/blob/bdad42fac4c6ea31cd839d490c5be3752426cc09/cmd/ttn-lw-cli/commands/end_device_templates.go#L404-L416)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.
> reference to e was used in a composite literal at line 414
[Click here to see the code in its original context.](https://github.com/phoebus101/ttnstack/blob/bdad42fac4c6ea31cd839d490c5be3752426cc09/cmd/ttn-lw-cli/commands/end_device_templates.go#L404-L416)
Click here to show the 13 line(s) of Go which triggered the analyzer.
```go
for _, e := range mapping {
switch {
case e.MappingKey != "" && e.MappingKey == inputEntry.MappingKey:
case e.EndDevice.ApplicationID != "" && e.EndDevice.ApplicationID == inputEntry.EndDevice.ApplicationID &&
e.EndDevice.DeviceID != "" && e.EndDevice.DeviceID == inputEntry.EndDevice.DeviceID:
case e.EndDevice.DevEUI != nil && inputEntry.EndDevice.DevEUI != nil && e.EndDevice.DevEUI.Equal(*inputEntry.EndDevice.DevEUI):
case e.EndDevice.EndDeviceIdentifiers.IsZero():
default:
continue
}
mappedEntry = &e
break
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: bdad42fac4c6ea31cd839d490c5be3752426cc09
Contributor guide
No contributing guide indexed for this repository
Research direction
Read cmd/ttn-lw-cli/commands/end_device_templates.go around lines 404-416 and review how the range variable e is referenced when mappedEntry is assigned. Decide whether this instance is a Bug, Mitigated, or Desirable Behavior, then leave the corresponding reaction on the issue.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- cli
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 25/100