github-vet / github-vet/rangeloop-pointer-findings
DCSO/fever: cmd/fever/cmds/run.go; 3 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [DCSO/fever](https://www.github.com/DCSO/fever) at [cmd/fever/cmds/run.go](https://github.com/DCSO/fever/blob/eb8e7831e0fc023b8fcf4dfc13f9c428f1386403/cmd/fever/cmds/run.go#L563-L565)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.
> function call at line 564 may store a reference to v
[Click here to see the code in its original context.](https://github.com/DCSO/fever/blob/eb8e7831e0fc023b8fcf4dfc13f9c428f1386403/cmd/fever/cmds/run.go#L563-L565)
Click here to show the 3 line(s) of Go which triggered the analyzer.
```go
for v := range inputChan {
dispatcher.Dispatch(&v)
}
```
Click here to show extra information the analyzer produced.
```
The following graphviz dot graph describes paths through the callgraph that could lead to a function which writes a pointer argument:
digraph G {
"(Dispatch, 1)" -> {"(Consume, 1)";}
"(Consume, 1)" -> {}
}
No path was found through the callgraph that could lead to a function which passes a pointer to third-party code.
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: eb8e7831e0fc023b8fcf4dfc13f9c428f1386403
Contributor guide
No contributing guide indexed for this repository
Research direction
Start with cmd/fever/cmds/run.go at lines 563-565 and inspect the shown call path from Dispatch to Consume. Determine whether passing the range variable address is a bug, mitigated, or desirable behavior, then classify the issue with the corresponding reaction.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- cli
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100