github-vet / github-vet/rangeloop-pointer-findings
nov1n/kubernetes-workflow: pkg/client/workflows.go; 9 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [nov1n/kubernetes-workflow](https://www.github.com/nov1n/kubernetes-workflow) at [pkg/client/workflows.go](https://github.com/nov1n/kubernetes-workflow/blob/4ad97e9602f448d4db5a9a47dca6392cf87ee9ee/pkg/client/workflows.go#L195-L203)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.
> reference to wf was used in a composite literal at line 199
[Click here to see the code in its original context.](https://github.com/nov1n/kubernetes-workflow/blob/4ad97e9602f448d4db5a9a47dca6392cf87ee9ee/pkg/client/workflows.go#L195-L203)
Click here to show the 9 line(s) of Go which triggered the analyzer.
```go
for k, wf := range w.nameMap {
if _, ok := listMap[k]; ok == false {
watcher.Result <- k8sWatch.Event{
Type: k8sWatch.Deleted,
Object: &wf,
}
delete(w.nameMap, k)
}
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: 4ad97e9602f448d4db5a9a47dca6392cf87ee9ee
Contributor guide
No contributing guide indexed for this repository
Research direction
Start at pkg/client/workflows.go lines 195-203 and read the linked commit context to understand how the range variable is used in the watch event. Decide whether the analyzer finding is a bug, mitigated, or desirable behavior, then leave the corresponding reaction.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100