github-vet / github-vet/rangeloop-pointer-findings

contiv/vpp: plugins/crd/validator/l2/l2_validator.go; 11 LoC

Open
#12,646 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [contiv/vpp](https://www.github.com/contiv/vpp) at [plugins/crd/validator/l2/l2_validator.go](https://github.com/contiv/vpp/blob/c6ed55900e77dd14b8705dc6fa6d90f7a8b70b56/plugins/crd/validator/l2/l2_validator.go#L170-L180)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to bdomain is reassigned at line 178

[Click here to see the code in its original context.](https://github.com/contiv/vpp/blob/c6ed55900e77dd14b8705dc6fa6d90f7a8b70b56/plugins/crd/validator/l2/l2_validator.go#L170-L180)

Click here to show the 11 line(s) of Go which triggered the analyzer.

```go
for _, bdomain := range node.NodeBridgeDomains {
if bdomain.Value.Name == "vxlanBD" {
if vxLanBD != nil {
errString := fmt.Sprintf("multiple VXLAN BDs - skipped BD validation")
errCnt++
v.Report.AppendToNodeReport(node.Name, errString)
continue validateNodeBD
}
vxLanBD = &bdomain
}
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: c6ed55900e77dd14b8705dc6fa6d90f7a8b70b56

Contributor guide

No contributing guide indexed for this repository

Research direction

Read plugins/crd/validator/l2/l2_validator.go around lines 170-180 at commit c6ed55900e77dd14b8705dc6fa6d90f7a8b70b56, then inspect how vxLanBD is used after the loop. Determine whether taking &bdomain creates an unintended range-variable reference, and classify the finding as Bug, Mitigated, or Desirable Behavior with the requested reaction.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
networking
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.