smartfog/fogflow: broker/thinBroker.go; 16 LoC

Found a possible issue in [smartfog/fogflow](https://www.github.com/smartfog/fogflow) at [broker/thinBroker.go](https://github.com/smartfog/fogflow/blob/ded2cd97539f2c66a82f4d4febf67e765c196cfa/broker/thinBroker.go#L536-L551)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> function call which takes a reference to ctxElem at line 547 may start a goroutine

[Click here to see the code in its original context.](https://github.com/smartfog/fogflow/blob/ded2cd97539f2c66a82f4d4febf67e765c196cfa/broker/thinBroker.go#L536-L551)

Click here to show the 16 line(s) of Go which triggered the analyzer.

```go
for _, ctxElem := range updateCtxReq.ContextElements {
// just in case this is orion ngsi v1
ctxElem.SetEntityID()
// params[0] has FiwareService header and params[1] has FiwareServicePath
if fiwareHeadersExist {
tb.updateIdWithFiwareHeaders(&ctxElem, params[0], params[1])
}

brokerURL := tb.queryOwnerOfEntity(ctxElem.Entity.ID)

if brokerURL == tb.myProfile.MyURL {
tb.UpdateContext2LocalSite(&ctxElem, w)
} else {
tb.UpdateContext2RemoteSite(&ctxElem, updateCtxReq.UpdateAction, brokerURL)
}
}

```

Click here to show extra information the analyzer produced.

```
The following graphviz dot graph describes paths through the callgraph that could lead to a function calling a goroutine:
digraph G {
"(UpdateContext2LocalSite, 2)" -> {"(notifySubscribers, 2)";"(notifySubscribersV2, 2)";}
"(notifySubscribers, 2)" -> {}
"(notifySubscribersV2, 2)" -> {}
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: ded2cd97539f2c66a82f4d4febf67e765c196cfa

Start with broker/thinBroker.go lines 536-551 at commit ded2cd97539f2c66a82f4d4febf67e765c196cfa. Trace UpdateContext2LocalSite and the notifySubscribers and notifySubscribersV2 paths shown in the analyzer graph, then determine whether the range-loop reference can cause incorrect goroutine behavior. Done means classifying the finding as Bug, Mitigated, or Desirable Behavior and leaving the corresponding reaction.

Written by the indexing model from the issue text.