github-vet / github-vet/rangeloop-pointer-findings
turbinelabs/rotor: plugins/marathon/marathon.go; 17 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [turbinelabs/rotor](https://www.github.com/turbinelabs/rotor) at [plugins/marathon/marathon.go](https://github.com/turbinelabs/rotor/blob/1fc1f69dcaef7980421d362e11e895897450bcaf/plugins/marathon/marathon.go#L338-L354)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.
>
[Click here to see the code in its original context.](https://github.com/turbinelabs/rotor/blob/1fc1f69dcaef7980421d362e11e895897450bcaf/plugins/marathon/marathon.go#L338-L354)
Click here to show the 17 line(s) of Go which triggered the analyzer.
```go
for _, task := range tasks.Tasks {
totalCount++
if m.filter != nil {
if !m.filter(&m.marathonCollectorSettings, app, &task, labels) {
// If the filter fails for this task, continue to the next task.
filteredCount++
continue
}
}
host, port, err := m.findAddr(task)
if err != nil {
console.Error().Printf("Task '%s': %s", task.ID, err.Error())
} else {
cluster.Instances = append(cluster.Instances, m.makeInstance(host, port, labels))
}
}
```
Click here to show extra information the analyzer produced.
```
No path was found through the callgraph that could lead to a function which writes a pointer argument.
No path was found through the callgraph that could lead to a function which passes a pointer to third-party code.
root signature {filter 4} was not found in the callgraph; reference was passed directly to third-party code
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: 1fc1f69dcaef7980421d362e11e895897450bcaf
Contributor guide
No contributing guide indexed for this repository
Research direction
Read plugins/marathon/marathon.go around lines 338-354 and the linked range-loop analyzer guidance. Inspect how the task address is passed to m.filter and m.findAddr, then classify the finding with the requested reaction; done means the instance is marked Bug, Mitigated, or Desirable Behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100