github-vet / github-vet/rangeloop-pointer-findings

kleveross/ormb: pkg/oras/cache/cache.go; 6 LoC

Open
#12,559 0 comments 0 reactions 0 assignees View on GitHub
fresh tiny
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [kleveross/ormb](https://www.github.com/kleveross/ormb) at [pkg/oras/cache/cache.go](https://github.com/kleveross/ormb/blob/491a73dce0a32b78e1a59354ea9618e4fca58e8b/pkg/oras/cache/cache.go#L114-L119)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to layer is reassigned at line 117

[Click here to see the code in its original context.](https://github.com/kleveross/ormb/blob/491a73dce0a32b78e1a59354ea9618e4fca58e8b/pkg/oras/cache/cache.go#L114-L119)

Click here to show the 6 line(s) of Go which triggered the analyzer.

```go
for _, layer := range manifest.Layers {
switch layer.MediaType {
case consts.MediaTypeModelContentLayer:
contentLayer = &layer
}
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 491a73dce0a32b78e1a59354ea9618e4fca58e8b

Contributor guide

No contributing guide indexed for this repository

Research direction

Read pkg/oras/cache/cache.go at lines 114-119 and the surrounding cache logic first. Confirm the analyzer finding against the intended contentLayer selection, then check any existing tests for this path; done means the range-loop reference behavior is classified and any resulting change is covered by the relevant test.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.