github-vet / github-vet/rangeloop-pointer-findings

TicketsBot/TicketsGo: bot/command/removesupport.go; 19 LoC

Open
#12,512 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [TicketsBot/TicketsGo](https://www.github.com/TicketsBot/TicketsGo) at [bot/command/removesupport.go](https://github.com/TicketsBot/TicketsGo/blob/f95f46fb3784b5df662d9018c7262702a58024d8/bot/command/removesupport.go#L51-L69)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> range-loop variable mention used in defer or goroutine at line 64

[Click here to see the code in its original context.](https://github.com/TicketsBot/TicketsGo/blob/f95f46fb3784b5df662d9018c7262702a58024d8/bot/command/removesupport.go#L51-L69)

Click here to show the 19 line(s) of Go which triggered the analyzer.

```go
for _, mention := range ctx.Message.Mentions {
// Verify that we're allowed to perform the remove operation
if guild.OwnerId == mention.Id {
ctx.SendEmbed(utils.Red, "Error", "The guild owner must be an admin")
continue
}

if ctx.Author.Id == mention.Id {
ctx.SendEmbed(utils.Red, "Error", "You cannot revoke your own privileges")
continue
}

go func() {
if err := database.Client.Permissions.RemoveSupport(ctx.GuildId, mention.Id); err != nil {
sentry.ErrorWithContext(err, ctx.ToErrorContext())
ctx.ReactWithCross()
}
}()
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: f95f46fb3784b5df662d9018c7262702a58024d8

Contributor guide

No contributing guide indexed for this repository

Research direction

Start in bot/command/removesupport.go at lines 51-69 and review the range loop together with the goroutine that removes support. Verify the analyzer finding is resolved and that each mentioned user is handled correctly; the issue provides no test file, so inspect the command entry point and existing project checks for validation.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.