github-vet / github-vet/rangeloop-pointer-findings

TicketsBot/TicketsGo: bot/command/removesupport.go; 8 LoC

Open
#12,511 0 comments 0 reactions 0 assignees View on GitHub
fresh tiny
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [TicketsBot/TicketsGo](https://www.github.com/TicketsBot/TicketsGo) at [bot/command/removesupport.go](https://github.com/TicketsBot/TicketsGo/blob/f95f46fb3784b5df662d9018c7262702a58024d8/bot/command/removesupport.go#L96-L103)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> range-loop variable role used in defer or goroutine at line 98

[Click here to see the code in its original context.](https://github.com/TicketsBot/TicketsGo/blob/f95f46fb3784b5df662d9018c7262702a58024d8/bot/command/removesupport.go#L96-L103)

Click here to show the 8 line(s) of Go which triggered the analyzer.

```go
for _, role := range roles {
go func() {
if err := database.Client.RolePermissions.RemoveSupport(ctx.GuildId, role); err != nil {
sentry.ErrorWithContext(err, ctx.ToErrorContext())
ctx.ReactWithCross()
}
}()
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: f95f46fb3784b5df662d9018c7262702a58024d8

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reading bot/command/removesupport.go at lines 96-103 and inspect the reported range-loop capture in the goroutine. Confirm whether each goroutine uses the intended role, then verify that the analyzer warning is resolved and the command behavior remains correct.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.