github-vet / github-vet/rangeloop-pointer-findings

TicketsBot/TicketsGo: bot/command/addadmin.go; 7 LoC

Open
#12,510 0 comments 0 reactions 0 assignees View on GitHub
fresh tiny
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [TicketsBot/TicketsGo](https://www.github.com/TicketsBot/TicketsGo) at [bot/command/addadmin.go](https://github.com/TicketsBot/TicketsGo/blob/f95f46fb3784b5df662d9018c7262702a58024d8/bot/command/addadmin.go#L51-L57)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> range-loop variable mention used in defer or goroutine at line 53

[Click here to see the code in its original context.](https://github.com/TicketsBot/TicketsGo/blob/f95f46fb3784b5df662d9018c7262702a58024d8/bot/command/addadmin.go#L51-L57)

Click here to show the 7 line(s) of Go which triggered the analyzer.

```go
for _, mention := range ctx.Message.Mentions {
go func() {
if err := database.Client.Permissions.AddAdmin(ctx.GuildId, mention.Id); err != nil {
sentry.ErrorWithContext(err, ctx.ToErrorContext())
}
}()
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: f95f46fb3784b5df662d9018c7262702a58024d8

Contributor guide

No contributing guide indexed for this repository

Research direction

Start in bot/command/addadmin.go at the loop around lines 51-57 and inspect how each mentioned user is passed to AddAdmin from the goroutine. Check the project's existing Go tests or test entry points, then verify that every mentioned ID is handled correctly without range-loop capture; done means the analyzer finding is resolved and admin additions still work.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.