github-vet / github-vet/rangeloop-pointer-findings
harrowio/harrow: api/src/github.com/harrowio/harrow/domain/environment.go; 14 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [harrowio/harrow](https://www.github.com/harrowio/harrow) at [api/src/github.com/harrowio/harrow/domain/environment.go](https://github.com/harrowio/harrow/blob/a8e4d9d623be4e7908846414be2eb884580bf7b9/api/src/github.com/harrowio/harrow/domain/environment.go#L100-L113)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.
> reference to selfValue was used in a composite literal at line 110
[Click here to see the code in its original context.](https://github.com/harrowio/harrow/blob/a8e4d9d623be4e7908846414be2eb884580bf7b9/api/src/github.com/harrowio/harrow/domain/environment.go#L100-L113)
Click here to show the 14 line(s) of Go which triggered the analyzer.
```go
for selfName, selfValue := range self.M {
if otherValue, found := other.M[selfName]; !found {
result.Removed = append(result.Removed, &EnvironmentVariable{
Name: selfName,
Value: selfValue,
})
} else if otherValue != selfValue {
result.Changed = append(result.Changed, &EnvironmentVariable{
Name: selfName,
Value: otherValue,
OldValue: &selfValue,
})
}
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: a8e4d9d623be4e7908846414be2eb884580bf7b9
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.