github-vet / github-vet/rangeloop-pointer-findings
openshift-kni/performance-addon-operators: functests/utils/discovery/discovery.go; 13 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [openshift-kni/performance-addon-operators](https://www.github.com/openshift-kni/performance-addon-operators) at [functests/utils/discovery/discovery.go](https://github.com/openshift-kni/performance-addon-operators/blob/38436e8460a8d1faee4f15554a5ef3d083e8d096/functests/utils/discovery/discovery.go#L52-L64)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.
> reference to profile is reassigned at line 61
[Click here to see the code in its original context.](https://github.com/openshift-kni/performance-addon-operators/blob/38436e8460a8d1faee4f15554a5ef3d083e8d096/functests/utils/discovery/discovery.go#L52-L64)
Click here to show the 13 line(s) of Go which triggered the analyzer.
```go
for _, profile := range performanceProfiles {
selector := labels.SelectorFromSet(profile.Spec.NodeSelector)
profileNodes := &corev1.NodeList{}
if err := testclient.Client.List(context.TODO(), profileNodes, &client.ListOptions{LabelSelector: selector}); err != nil {
return nil, err
}
if len(profileNodes.Items) > maxNodesNumber {
currentProfile = &profile
maxNodesNumber = len(profileNodes.Items)
}
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: 38436e8460a8d1faee4f15554a5ef3d083e8d096
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.