github-vet / github-vet/rangeloop-pointer-findings
untangle/ngfw_upstream: drive/drive-0.3.1/src/github.com/odeke-em/drive/src/fetch.go; 9 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [untangle/ngfw_upstream](https://www.github.com/untangle/ngfw_upstream) at [drive/drive-0.3.1/src/github.com/odeke-em/drive/src/fetch.go](https://github.com/untangle/ngfw_upstream/blob/292e09f6d9b283a97073ab7ea71214e905bc19af/drive/drive-0.3.1/src/github.com/odeke-em/drive/src/fetch.go#L199-L207)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.
> range-loop variable id used in defer or goroutine at line 203
[Click here to see the code in its original context.](https://github.com/untangle/ngfw_upstream/blob/292e09f6d9b283a97073ab7ea71214e905bc19af/drive/drive-0.3.1/src/github.com/odeke-em/drive/src/fetch.go#L199-L207)
Click here to show the 9 line(s) of Go which triggered the analyzer.
```go
for id, _ := range ids {
go func(qId string) {
f, err := g.rem.FindById(qId)
if false && err != nil && err != ErrPathNotExists {
g.log.LogErrln(id, err, "x")
}
delivery <- f
}(id)
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: 292e09f6d9b283a97073ab7ea71214e905bc19af
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.