github-vet / github-vet/rangeloop-pointer-findings
yogetter/MonitorOpenStackVM: client/client.go; 13 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [yogetter/MonitorOpenStackVM](https://www.github.com/yogetter/MonitorOpenStackVM) at [client/client.go](https://github.com/yogetter/MonitorOpenStackVM/blob/304c009fe3a94a247a402e2a8feaed6bfa0556e7/client/client.go#L64-L76)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.
> function call at line 65 may store a reference to dom
[Click here to see the code in its original context.](https://github.com/yogetter/MonitorOpenStackVM/blob/304c009fe3a94a247a402e2a8feaed6bfa0556e7/client/client.go#L64-L76)
Click here to show the 13 line(s) of Go which triggered the analyzer.
```go
for i, dom := range doms {
go GetVmStats(&VMs[i], &dom, conn, VmQueue)
VMs[i] = *<-VmQueue
//Ensure VM's ID is same
if VMs[i].Id == tmp[i].Id {
VMs[i].SetAllValue(tmp[i])
} else {
break
return true
}
//log.Println(VMs[i].GetValue())
VMs[i].dom.Free()
}
```
Click here to show extra information the analyzer produced.
```
The following graphviz dot graph describes paths through the callgraph that could lead to a function which writes a pointer argument:
digraph G {
"(GetVmStats, 4)" -> {}
}
No path was found through the callgraph that could lead to a function which passes a pointer to third-party code.
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: 304c009fe3a94a247a402e2a8feaed6bfa0556e7
Contributor guide
No contributing guide indexed for this repository
Research direction
Read client/client.go lines 64-76 and inspect GetVmStats, focusing on the range variable dom passed to the goroutine. Compare the analyzer's warning with the shown Go code and classify the finding by leaving the appropriate Bug, Mitigated, or Desirable Behavior reaction.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100