github-vet / github-vet/rangeloop-pointer-findings
jacec/effective-go: command/channelcommand.go; 7 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [jacec/effective-go](https://www.github.com/jacec/effective-go) at [command/channelcommand.go](https://github.com/jacec/effective-go/blob/6217887d53ce2c9b3e3645607b65228415442732/command/channelcommand.go#L88-L94)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.
> range-loop variable req used in defer or goroutine at line 91
[Click here to see the code in its original context.](https://github.com/jacec/effective-go/blob/6217887d53ce2c9b3e3645607b65228415442732/command/channelcommand.go#L88-L94)
Click here to show the 7 line(s) of Go which triggered the analyzer.
```go
for req := range queue {
sem <- 1
go func() {
process(req) // Buggy; see explanation below.
<-sem
}()
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: 6217887d53ce2c9b3e3645607b65228415442732
Contributor guide
No contributing guide indexed for this repository
Research direction
Read command/channelcommand.go at lines 88-94 and the linked analyzer guidance about range-loop variables used in goroutines. Decide whether this instance should be classified as a Bug, Mitigated, or Desirable Behavior, then leave the corresponding reaction; completion is recorded by that classification.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 35/100