github-vet / github-vet/rangeloop-pointer-findings
mohuishou/scu: jwc/evaluate/evaluate.go; 10 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [mohuishou/scu](https://www.github.com/mohuishou/scu) at [jwc/evaluate/evaluate.go](https://github.com/mohuishou/scu/blob/f18709083717f53b894a30eff918983f112dadd3/jwc/evaluate/evaluate.go#L185-L194)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.
> reference to v is reassigned at line 186
[Click here to see the code in its original context.](https://github.com/mohuishou/scu/blob/f18709083717f53b894a30eff918983f112dadd3/jwc/evaluate/evaluate.go#L185-L194)
Click here to show the 10 line(s) of Go which triggered the analyzer.
```go
for i, v := range evaluates {
e := &v
e.update()
if e.Status == 1 {
comment, answer, _, _ := e.getInfo(c.Clone())
e.Star = answer.average(e.TeacherType)
e.Comment = comment
}
evaluates[i] = *e
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: f18709083717f53b894a30eff918983f112dadd3
Contributor guide
No contributing guide indexed for this repository
Research direction
Read jwc/evaluate/evaluate.go around lines 185-194 and inspect the reported range-loop reference to v. Compare the analyzer message with the surrounding code, then leave a reaction classifying the finding as Bug, Mitigated, or Desirable Behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 38/100