github-vet / github-vet/rangeloop-pointer-findings

mendersoftware/workflows: store/mongo/datastore_mongo.go; 21 LoC

Open
#12,304 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [mendersoftware/workflows](https://www.github.com/mendersoftware/workflows) at [store/mongo/datastore_mongo.go](https://github.com/mendersoftware/workflows/blob/e7b4b6c82743faf2643a7ae2a20b20c646b648c9/store/mongo/datastore_mongo.go#L222-L242)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to workflow is reassigned at line 241

[Click here to see the code in its original context.](https://github.com/mendersoftware/workflows/blob/e7b4b6c82743faf2643a7ae2a20b20c646b648c9/store/mongo/datastore_mongo.go#L222-L242)

Click here to show the 21 line(s) of Go which triggered the analyzer.

```go
for i, workflow := range workflows {
if workflow.Name == "" {
return i, store.ErrWorkflowMissingName
}
workflowDb, _ := db.GetWorkflowByName(ctx, workflow.Name)
if workflowDb != nil && workflowDb.Version >= workflow.Version {
return i + 1, store.ErrWorkflowAlreadyExists
}
if workflowDb == nil || workflowDb.Version < workflow.Version {
upsert := true
opt := &mopts.UpdateOptions{
Upsert: &upsert,
}
query := bson.M{"_id": workflow.Name}
update := bson.M{"$set": workflow}
if _, err := collWflows.UpdateOne(ctx, query, update, opt); err != nil {
return i + 1, err
}
}
db.workflows[workflow.Name] = &workflow
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: e7b4b6c82743faf2643a7ae2a20b20c646b648c9

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.