github-vet / github-vet/rangeloop-pointer-findings
neugram/ng: typecheck/typecheck.go; 47 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [neugram/ng](https://www.github.com/neugram/ng) at [typecheck/typecheck.go](https://github.com/neugram/ng/blob/d472ff93d8726d1f45c0667ec893ca59d86768c4/typecheck/typecheck.go#L691-L737)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.
>
[Click here to see the code in its original context.](https://github.com/neugram/ng/blob/d472ff93d8726d1f45c0667ec893ca59d86768c4/typecheck/typecheck.go#L691-L737)
Click here to show the 47 line(s) of Go which triggered the analyzer.
```go
for _, cse := range s.Cases {
if cse.Default {
dflts++
if dflts > 1 {
c.errorfmt("multiple defaults in select")
}
}
for k := range set {
if parser.EqualStmt(k, cse.Stmt) {
c.errorfmt("duplicate case %s in select", cse.Stmt)
}
}
set[cse.Stmt] = struct{}{}
if cse.Stmt != nil {
switch st := cse.Stmt.(type) {
case *stmt.Assign:
if len(st.Right) != 1 {
c.errorfmt("select case must be receive send or assign recv")
return nil
}
sr, ok := st.Right[0].(*expr.Unary)
if !ok || sr.Op != token.ChanOp {
c.errorfmt("select case must be receive send or assign recv")
return nil
}
case *stmt.Send:
case *stmt.Simple:
sr, ok := st.Expr.(*expr.Unary)
if !ok || sr.Op != token.ChanOp {
c.errorfmt("select case must be receive send or assign recv")
return nil
}
default:
c.errorfmt("select case must be receive, send or assign recv")
return nil
}
}
func(cse *stmt.SelectCase) {
if cse.Stmt != nil {
c.pushScope()
defer c.popScope()
c.stmt(cse.Stmt, retType, retNames)
}
c.stmt(cse.Body, retType, retNames)
}(&cse)
}
```
Click here to show extra information the analyzer produced.
```
No path was found through the callgraph that could lead to a function which writes a pointer argument.
No path was found through the callgraph that could lead to a function which passes a pointer to third-party code.
root signature { 1} was not found in the callgraph; reference was passed directly to third-party code
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: d472ff93d8726d1f45c0667ec893ca59d86768c4
Contributor guide
No contributing guide indexed for this repository
Research direction
Start with the select-case handling in typecheck/typecheck.go at lines 691-737 and review the analyzer details attached to the issue. Determine whether the reported range-loop finding is a Bug, Mitigated, or Desirable Behavior, then record that classification with the corresponding reaction.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- compilers
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100