github-vet / github-vet/rangeloop-pointer-findings
duckbrain/ldss: lib/dl/queue.go; 26 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [duckbrain/ldss](https://www.github.com/duckbrain/ldss) at [lib/dl/queue.go](https://github.com/duckbrain/ldss/blob/c2b04549311af5bd8fe103e7280fe13dbf60eef7/lib/dl/queue.go#L129-L154)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.
> range-loop variable dl used in defer or goroutine at line 135
[Click here to see the code in its original context.](https://github.com/duckbrain/ldss/blob/c2b04549311af5bd8fe103e7280fe13dbf60eef7/lib/dl/queue.go#L129-L154)
Click here to show the 26 line(s) of Go which triggered the analyzer.
```go
for dl := range newDownloads {
dls := make(chan Status)
go func() {
for s := range dls {
statusUpdates <- DownloadStatus{
Status: s,
Downloader: dl,
Stage: Progress,
}
}
}()
statusUpdates <- DownloadStatus{
Downloader: dl,
Stage: Started,
}
err := dl.Download(dls)
close(dls)
statusUpdates <- DownloadStatus{
Status: Status{
Err: err,
Progress: 1,
},
Downloader: dl,
Stage: Complete,
}
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: c2b04549311af5bd8fe103e7280fe13dbf60eef7
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.