github-vet / github-vet/rangeloop-pointer-findings
aktau/gofinance: fquery/util.go; 3 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [aktau/gofinance](https://www.github.com/aktau/gofinance) at [fquery/util.go](https://github.com/aktau/gofinance/blob/fcac4fbc2d920dff5a5f2307a9fe26a647ebe7cb/fquery/util.go#L5-L7)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.
> reference to quote is reassigned at line 6
[Click here to see the code in its original context.](https://github.com/aktau/gofinance/blob/fcac4fbc2d920dff5a5f2307a9fe26a647ebe7cb/fquery/util.go#L5-L7)
Click here to show the 3 line(s) of Go which triggered the analyzer.
```go
for _, quote := range quotes {
m[quote.Symbol] = "e
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: fcac4fbc2d920dff5a5f2307a9fe26a647ebe7cb
Contributor guide
No contributing guide indexed for this repository
Research direction
Read fquery/util.go at lines 5-7 and inspect how the loop stores pointers in the map. Compare the behavior with the surrounding use of quotes, then classify the finding as Bug, Mitigated, or Desirable Behavior by leaving the corresponding reaction.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 30/100