github-vet / github-vet/rangeloop-pointer-findings
amlwwalker/wingit: _cuiinterface/interface.go; 3 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [amlwwalker/wingit](https://www.github.com/amlwwalker/wingit) at [_cuiinterface/interface.go](https://github.com/amlwwalker/wingit/blob/715658bfbc4b7d6e18ba7631236f00ff534d9af8/_cuiinterface/interface.go#L192-L194)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.
> function call at line 193 may store a reference to v
[Click here to see the code in its original context.](https://github.com/amlwwalker/wingit/blob/715658bfbc4b7d6e18ba7631236f00ff534d9af8/_cuiinterface/interface.go#L192-L194)
Click here to show the 3 line(s) of Go which triggered the analyzer.
```go
for _, v := range people {
c.CONTROLLER.AddContactToList(&v)
}
```
Click here to show extra information the analyzer produced.
```
The following graphviz dot graph describes paths through the callgraph that could lead to a function which writes a pointer argument:
digraph G {
"(AddContactToList, 1)" -> {}
}
No path was found through the callgraph that could lead to a function which passes a pointer to third-party code.
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: 715658bfbc4b7d6e18ba7631236f00ff534d9af8
Contributor guide
No contributing guide indexed for this repository
Research direction
Inspect _cuiinterface/interface.go at lines 192-194 and read the AddContactToList entry point mentioned by the analyzer. Determine whether the pointer to the range variable is retained, then classify the finding as Bug, Mitigated, or Desirable Behavior using the linked project guidance.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 30/100