Azure/ARO-RP: pkg/util/cluster/cluster.go; 36 LoC

Found a possible issue in [Azure/ARO-RP](https://www.github.com/Azure/ARO-RP) at [pkg/util/cluster/cluster.go](https://github.com/Azure/ARO-RP/blob/606bcb52e27dfd47e38772d021c5b9a2a6a7bb0f/pkg/util/cluster/cluster.go#L205-L240)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to principalID was used in a composite literal at line 214

[Click here to see the code in its original context.](https://github.com/Azure/ARO-RP/blob/606bcb52e27dfd47e38772d021c5b9a2a6a7bb0f/pkg/util/cluster/cluster.go#L205-L240)

Click here to show the 36 line(s) of Go which triggered the analyzer.

```go
for _, principalID := range []string{spID, fpSPID} {
for i := 0; i < 5; i++ {
_, err = c.roleassignments.Create(
ctx,
scope,
uuid.NewV4().String(),
mgmtauthorization.RoleAssignmentCreateParameters{
RoleAssignmentProperties: &mgmtauthorization.RoleAssignmentProperties{
RoleDefinitionID: to.StringPtr("/subscriptions/" + c.env.SubscriptionID() + "/providers/Microsoft.Authorization/roleDefinitions/" + rbac.RoleNetworkContributor),
PrincipalID: &principalID,
PrincipalType: mgmtauthorization.ServicePrincipal,
},
},
)

// Ignore if the role assignment already exists
if detailedError, ok := err.(autorest.DetailedError); ok {
if detailedError.StatusCode == http.StatusConflict {
err = nil
}
}

// TODO: tighten this error check
if err != nil && i < 4 {
// Sometimes we see HashConflictOnDifferentRoleAssignmentIds.
// Retry a few times.
c.log.Print(err)
continue
}
if err != nil {
return err
}

break
}
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 606bcb52e27dfd47e38772d021c5b9a2a6a7bb0f