github-vet / github-vet/rangeloop-pointer-findings
shibukawa/curl_as_dsl: client/xhr/generator.go; 12 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [shibukawa/curl_as_dsl](https://www.github.com/shibukawa/curl_as_dsl) at [client/xhr/generator.go](https://github.com/shibukawa/curl_as_dsl/blob/8f4fb260eca14c350d683c94dde45a62029b5c2c/client/xhr/generator.go#L193-L204)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.
> reference to data was used in a composite literal at line 198
[Click here to see the code in its original context.](https://github.com/shibukawa/curl_as_dsl/blob/8f4fb260eca14c350d683c94dde45a62029b5c2c/client/xhr/generator.go#L193-L204)
Click here to show the 12 line(s) of Go which triggered the analyzer.
```go
for i, data := range options.ProcessedData {
fileName := data.FileName()
if fileName != "" {
isText := data.Type == common.DataAsciiType
file := &ExternalFile{
Data: &data,
FileName: fileName,
TextType: isText,
}
generator.ExternalFiles[i] = file
}
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: 8f4fb260eca14c350d683c94dde45a62029b5c2c
Contributor guide
No contributing guide indexed for this repository
Research direction
Start at client/xhr/generator.go lines 193-204 and read the linked range-loop context. Decide whether taking a reference to data in the composite literal is a bug, mitigated, or desirable behavior, then record that classification with the requested reaction.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- web-dev
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 35/100