github-vet / github-vet/rangeloop-pointer-findings
mkdadi/BTP: smartfog/go/src/fogflow/broker/thinBroker.go; 18 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [mkdadi/BTP](https://www.github.com/mkdadi/BTP) at [smartfog/go/src/fogflow/broker/thinBroker.go](https://github.com/mkdadi/BTP/blob/382a5ca49ff42e68b7683a9a6ce6a410efe91616/smartfog/go/src/fogflow/broker/thinBroker.go#L386-L403)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.
> function call which takes a reference to ctxElem at line 393 may start a goroutine
[Click here to see the code in its original context.](https://github.com/mkdadi/BTP/blob/382a5ca49ff42e68b7683a9a6ce6a410efe91616/smartfog/go/src/fogflow/broker/thinBroker.go#L386-L403)
Click here to show the 18 line(s) of Go which triggered the analyzer.
```go
for _, ctxElem := range updateCtxReq.ContextElements {
tb.entities_lock.Lock()
eid := ctxElem.Entity.ID
hasUpdatedMetadata := hasUpdatedMetadata(&ctxElem, tb.entities[eid])
tb.entities_lock.Unlock()
// propogate this update to its subscribers
go tb.notifySubscribers(&ctxElem)
// apply the new update to the entity in the entity map
tb.updateContextElement(&ctxElem)
// register the entity if there is any changes on attribute list, domain metadata
if hasUpdatedMetadata == true {
//fmt.Println("===========has updated metadata============")
tb.registerContextElement(&ctxElem)
}
}
```
Click here to show extra information the analyzer produced.
```
The following graphviz dot graph describes paths through the callgraph that could lead to a function calling a goroutine:
digraph G {
"(notifySubscribers, 1)" -> {}
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: 382a5ca49ff42e68b7683a9a6ce6a410efe91616
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.