github-vet / github-vet/rangeloop-pointer-findings

yiduoyunQ/sm: sm-svr/sm/handler.go; 28 LoC

Open
#12,228 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [yiduoyunQ/sm](https://www.github.com/yiduoyunQ/sm) at [sm-svr/sm/handler.go](https://github.com/yiduoyunQ/sm/blob/c7f7cdfaed02d0f0292619b29e6ba1768bcda0d1/sm-svr/sm/handler.go#L492-L519)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> range-loop variable userPrivilege used in defer or goroutine at line 499

[Click here to see the code in its original context.](https://github.com/yiduoyunQ/sm/blob/c7f7cdfaed02d0f0292619b29e6ba1768bcda0d1/sm-svr/sm/handler.go#L492-L519)

Click here to show the 28 line(s) of Go which triggered the analyzer.

```go
for _, userPrivilege := range dbUserPrivilegesTmp {
for _, shardV := range sm.topology.DataNodeGroup {
for dbName, dbInfo := range shardV {
if dbInfo.Type == structs.Master {
delCount++
go func(dbName, userPrivilegeName string) {
for userName := range sm.topology.ProxyUsers {
if userPrivilege.Name == userName {
//err := sm.swarm.DelDBUser(dbName, userPrivilegeName, strings.Join(addIps, ","))
//if err != nil {
// ch <- err
// return
//}
for _, ip := range addIPs {
err := sm.swarm.DelDBUser(dbName, userPrivilegeName, ip)
if err != nil {
ch <- err
return
}
}
}
}
ch <- nil
}(dbName, userPrivilege.Name)
}
}
}
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: c7f7cdfaed02d0f0292619b29e6ba1768bcda0d1

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.