github-vet / github-vet/rangeloop-pointer-findings

capitalone/checks-out: web/status_hook.go; 130 LoC

Open
#12,227 0 comments 0 reactions 0 assignees View on GitHub
fresh large
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [capitalone/checks-out](https://www.github.com/capitalone/checks-out) at [web/status_hook.go](https://github.com/capitalone/checks-out/blob/d50294fea3e50efecb96302ed36174575045e212/web/status_hook.go#L72-L201)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to v was used in a composite literal at line 97

[Click here to see the code in its original context.](https://github.com/capitalone/checks-out/blob/d50294fea3e50efecb96302ed36174575045e212/web/status_hook.go#L72-L201)

Click here to show the 130 line(s) of Go which triggered the analyzer.

```go
for _, v := range pullRequests {
mw := ¬ifier.MessageWrapper{
MessageHeader: notifier.MessageHeader{
PrName: v.Issue.Title,
PrNumber: v.Issue.Number,
Slug: hook.Repo.Slug,
},
}

id := fmt.Sprintf("%d", v.Number)
//if all of the statuses are success, then merge and create a tag for the version
if v.Branch.Mergeable {
result := StatusResponse{}

files, err := getPullRequestFiles(c, user, hook.Repo, v.Number)
if err != nil {
generateError("Unable to get pull request files", err, v, hook.Repo.Slug, &result, mw)
merged[id] = result
sendMessage(c, config, mw)
continue
}

req := &model.ApprovalRequest{
Config: config,
Maintainer: maintainer,
PullRequest: &v,
Repository: repo,
Files: files,
}

policy := model.FindApprovalPolicy(req)
mergeConfig := req.Config.GetMergeConfig(policy)

if !mergeConfig.Enable {
result.Info = "merge config not enabled"
merged[id] = result
sendMessage(c, config, mw)
continue
}

success, err := remote.HasRequiredStatus(c, user, hook.Repo, v.Branch.BaseName, v.Branch.CompareSHA)

if err != nil {
generateError("Unable to test commit statuses", err, v, hook.Repo.Slug, &result, mw)
merged[id] = result
sendMessage(c, config, mw)
continue
}

if !success {
result.Info = "required status checks are not passed"
merged[id] = result
sendMessage(c, config, mw)
continue
}

if mergeConfig.UpToDate {
behind, err2 := isBehind(c, user, repo, v.Branch)
if err2 != nil {
generateError("Unable to compare branches", err2, v, hook.Repo.Slug, &result, mw)
merged[id] = result
sendMessage(c, config, mw)
continue
}
if behind {
result.Info = "compare branch is behind base branch"
merged[id] = result
sendMessage(c, config, mw)
continue
}
}

SHA, err := doMerge(c, user, hook, req, policy, mergeConfig.Method)

if err != nil {
generateError("Unable to merge pull request", err, v, hook.Repo.Slug, &result, mw)
merged[id] = result
sendMessage(c, config, mw)
continue
}

mw.Messages = append(mw.Messages, notifier.MessageInfo{
Message: "merged",
Type: model.CommentMerge,
})

result.SHA = SHA

tag, err := tagIfEnabled(c, user, hook, req, policy, SHA)
if err != nil {
generateError("Unable to tag", err, v, hook.Repo.Slug, &result, mw)
merged[id] = result
sendMessage(c, config, mw)
continue
}

result.Tag = tag

if tag != "" {
mw.Messages = append(mw.Messages, notifier.MessageInfo{
Message: fmt.Sprintf("Tag %s has been added", tag),
Type: model.CommentTag,
})
}

if mergeConfig.Delete && eligibleForDeletion(req, mw) {
err = doMergeDelete(c, user, hook, req)
if err != nil {
generateError("Unable to delete merged branch", err, v, hook.Repo.Slug, &result, mw)
merged[id] = result
sendMessage(c, config, mw)
continue
}
mw.Messages = append(mw.Messages, notifier.MessageInfo{
Message: fmt.Sprintf("Branch %s has been deleted", req.PullRequest.Branch.CompareName),
Type: model.CommentDelete,
})
}

if config.Deployment.Enable {
doDeployment(c, user, config, hook, v.Branch.BaseName)
mw.Messages = append(mw.Messages, notifier.MessageInfo{
Message: fmt.Sprintf("Deployment has been triggered from branch %s", v.Branch.BaseName),
Type: model.CommentDeployment,
})
}
merged[id] = result
sendMessage(c, config, mw)
}
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: d50294fea3e50efecb96302ed36174575045e212

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.