github-vet / github-vet/rangeloop-pointer-findings
kubernetes/legacy-cloud-providers: vsphere/vsphere_util.go; 11 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [kubernetes/legacy-cloud-providers](https://www.github.com/kubernetes/legacy-cloud-providers) at [vsphere/vsphere_util.go](https://github.com/kubernetes/legacy-cloud-providers/blob/6bf94e592759ab17ccb466b1cb784a0aa348ff13/vsphere/vsphere_util.go#L637-L647)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.
> range-loop variable nodeNames used in defer or goroutine at line 641
[Click here to see the code in its original context.](https://github.com/kubernetes/legacy-cloud-providers/blob/6bf94e592759ab17ccb466b1cb784a0aa348ff13/vsphere/vsphere_util.go#L637-L647)
Click here to show the 11 line(s) of Go which triggered the analyzer.
```go
for _, nodeNames := range dcNodes {
// Start go routines per VC-DC to check disks are attached
wg.Add(1)
go func(nodes []k8stypes.NodeName) {
err := vs.checkNodeDisks(ctx, nodeNames)
if err != nil {
klog.Errorf("Failed to check disk attached for nodes: %+v. err: %+v", nodes, err)
}
wg.Done()
}(nodeNames)
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: 6bf94e592759ab17ccb466b1cb784a0aa348ff13
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.