github-vet / github-vet/rangeloop-pointer-findings

opentradesolutions/openrisk: portfolio.go; 32 LoC

Open
#12,147 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [opentradesolutions/openrisk](https://www.github.com/opentradesolutions/openrisk) at [portfolio.go](https://github.com/opentradesolutions/openrisk/blob/5bf5a655d4375c478d03ab601401667887cf6b9d/portfolio.go#L253-L284)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> range-loop variable userId used in defer or goroutine at line 280

[Click here to see the code in its original context.](https://github.com/opentradesolutions/openrisk/blob/5bf5a655d4375c478d03ab601401667887cf6b9d/portfolio.go#L253-L284)

Click here to show the 32 line(s) of Go which triggered the analyzer.

```go
for userId, accs := range UserIdAccs {
rpt := make(map[string]interface{})
out[userId] = rpt
portfolios := UserPortfolios[userId]
accs2 := accs
go func() {
defer wg.Done()
for _, p := range portfolios {
usedAccs := getAccMatch(p.AccPatterns, accs2)
var positions []*Position
if len(usedAccs) > 0 {
for _, acc := range usedAccs {
tmp := Positions[acc]
for _, tmp2 := range tmp {
if p.Filter != nil {
v, _ := Evaluate(p.Filter, tmp2)
if v2, ok2 := v.(bool); ok2 {
if !v2 {
continue
}
}
}
positions = append(positions, tmp2)
}
}
}
if len(positions) > 0 {
rpt[p.Name] = p.Run(positions, userId)
}
}
}()
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 5bf5a655d4375c478d03ab601401667887cf6b9d

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.