aristanetworks/go-cvprac: api/provisioning.go; 31 LoC

Found a possible issue in [aristanetworks/go-cvprac](https://www.github.com/aristanetworks/go-cvprac) at [api/provisioning.go](https://github.com/aristanetworks/go-cvprac/blob/dc0d3711973a063058bf0a215f00722c4e0e35b0/api/provisioning.go#L1762-L1792)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to configlet is reassigned at line 1770

[Click here to see the code in its original context.](https://github.com/aristanetworks/go-cvprac/blob/dc0d3711973a063058bf0a215f00722c4e0e35b0/api/provisioning.go#L1762-L1792)

Click here to show the 31 line(s) of Go which triggered the analyzer.

```go
for _, configlet := range newconfiglets {
// don't process already applied configlets
if _, found := configletMap[configlet.Key]; found {
continue
}
// Reconcile configlet must be last in the list
// Store it separatly to be appended at very end of current and new configlets
if configlet.Reconciled {
reconcileConfiglet = &configlet
continue
}

// didn't find this configlet in either maps, so it's new
actionReqd = true

switch configlet.Type {
case "Static":
fallthrough
case "Generated":
fallthrough
case "Reconciled":
configletNames = append(configletNames, configlet.Name)
configletKeys = append(configletKeys, configlet.Key)
case "Builder":
builderNames = append(builderNames, configlet.Name)
builderKeys = append(builderKeys, configlet.Key)
default:
return false, nil, nil, nil, nil,
errors.Errorf("Configlet [%s] Invalid Type [%s]", configlet.Name, configlet.Type)
}
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: dc0d3711973a063058bf0a215f00722c4e0e35b0

Start in api/provisioning.go around lines 1762-1792 and inspect the surrounding provisioning function and its handling of configlets. Review the range-loop pointer finding and determine whether the reassignment affects the intended reconciliation behavior; done means the finding is resolved or documented with the expected behavior verified.

Written by the indexing model from the issue text.