github-vet / github-vet/rangeloop-pointer-findings
jncornett/whisper: cmd/p2pservice/p2pservice.go; 15 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [jncornett/whisper](https://www.github.com/jncornett/whisper) at [cmd/p2pservice/p2pservice.go](https:%2F%2Fgithub.com%2Fjncornett%2Fwhisper%2Fblob%2F833f1fdc3e5d1635b427425bf8589b1f097e4c55%2Fcmd%2Fp2pservice%2Fp2pservice.go%23L70-L84)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.
> range-loop variable recip used in defer or goroutine at line 72
[Click here to see the code in its original context.](https:%2F%2Fgithub.com%2Fjncornett%2Fwhisper%2Fblob%2F833f1fdc3e5d1635b427425bf8589b1f097e4c55%2Fcmd%2Fp2pservice%2Fp2pservice.go%23L70-L84)
Click here to show the 15 line(s) of Go which triggered the analyzer.
```go
for _, recip := range peers {
go func() {
client, err := rpc.DialHTTP("tcp", recip.Address)
if err != nil {
log.Print(err)
return
}
err = client.Call("Service.Push", &m, nil)
if err != nil {
log.Print(err)
}
// Success! now we should update the peer table to reflect that
e.peers.Add(recip.Address)
}()
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: 833f1fdc3e5d1635b427425bf8589b1f097e4c55
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.