github-vet / github-vet/rangeloop-pointer-findings
Meromen/rmq-receiver: service/rmq.go; 15 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [Meromen/rmq-receiver](https://www.github.com/Meromen/rmq-receiver) at [service/rmq.go](https://github.com/Meromen/rmq-receiver/blob/99ca559390900417dccfe111e443eeabfdb1573e/service/rmq.go#L132-L146)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.
> reference to delevery was used in a composite literal at line 142
[Click here to see the code in its original context.](https://github.com/Meromen/rmq-receiver/blob/99ca559390900417dccfe111e443eeabfdb1573e/service/rmq.go#L132-L146)
Click here to show the 15 line(s) of Go which triggered the analyzer.
```go
for delevery := range v {
func() {
body := db.Photo{}
err := json.Unmarshal(delevery.Body, &body)
if err != nil {
log.Printf("Faited to unmarshal msg: %s", err)
return
}
msg := RmqMessage{
body: &body,
ack: &delevery,
}
msgChan <- msg
}()
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: 99ca559390900417dccfe111e443eeabfdb1573e
Contributor guide
No contributing guide indexed for this repository
Research direction
Read service/rmq.go at lines 132-146 and inspect how the range variable is referenced in the RmqMessage composite literal. Determine whether the analyzer finding represents a bug, mitigated behavior, or desirable behavior, then leave the corresponding reaction on the issue.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 35/100