github-vet / github-vet/rangeloop-pointer-findings
pojntfx/nextcloud-talk-bot-framework: pkg/services/nextcloud_talk.go; 13 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [pojntfx/nextcloud-talk-bot-framework](https://www.github.com/pojntfx/nextcloud-talk-bot-framework) at [pkg/services/nextcloud_talk.go](https://github.com/pojntfx/nextcloud-talk-bot-framework/blob/90474c2ba6702dd355270a7d8ed4f9bfd3c3153c/pkg/services/nextcloud_talk.go#L39-L51)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.
>
[Click here to see the code in its original context.](https://github.com/pojntfx/nextcloud-talk-bot-framework/blob/90474c2ba6702dd355270a7d8ed4f9bfd3c3153c/pkg/services/nextcloud_talk.go#L39-L51)
Click here to show the 13 line(s) of Go which triggered the analyzer.
```go
for chat := range readChan {
go func(ichat *clients.Chat) {
if err := srv.Send(&nextcloudTalk.OutChat{
ID: int64(ichat.ID),
Token: ichat.Token,
ActorID: ichat.ActorID,
ActorDisplayName: ichat.ActorDisplayName,
Message: ichat.Message,
}); err != nil {
n.statusChan <- err.Error()
}
}(&chat)
}
```
Click here to show extra information the analyzer produced.
```
No path was found through the callgraph that could lead to a function which writes a pointer argument.
No path was found through the callgraph that could lead to a function which passes a pointer to third-party code.
root signature { 1} was not found in the callgraph; reference was passed directly to third-party code
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: 90474c2ba6702dd355270a7d8ed4f9bfd3c3153c
Contributor guide
No contributing guide indexed for this repository
Research direction
Start at pkg/services/nextcloud_talk.go around lines 39-51 and review the range loop, goroutine, and srv.Send call in the linked commit. Compare the analyzer output with the surrounding code and classify the finding as Bug, Mitigated, or Desirable Behavior using the project's stated reaction guidance.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100