codeamp/circuit: plugins/codeamp/release_handler.go; 78 LoC

Found a possible issue in [codeamp/circuit](https://www.github.com/codeamp/circuit) at [plugins/codeamp/release_handler.go](https://github.com/codeamp/circuit/blob/06371150b7aaaf104d41907c6f432a795238bf3c/plugins/codeamp/release_handler.go#L31-L108)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.

> function call at line 104 passes reference to releaseExtension to third-party code

[Click here to see the code in its original context.](https://github.com/codeamp/circuit/blob/06371150b7aaaf104d41907c6f432a795238bf3c/plugins/codeamp/release_handler.go#L31-L108)

Click here to show the 78 line(s) of Go which triggered the analyzer.

```go
for _, releaseExtension := range releaseExtensions {
projectExtension := model.ProjectExtension{}
if x.DB.Where("id = ?", releaseExtension.ProjectExtensionID).Find(&projectExtension).RecordNotFound() {
log.InfoWithFields("project extensions not found", log.Fields{
"id": releaseExtension.ProjectExtensionID,
"release_extension_id": releaseExtension.Model.ID,
})
return fmt.Errorf("project extension %s not found", releaseExtension.ProjectExtensionID)
}

extension := model.Extension{}
if x.DB.Where("id= ?", projectExtension.ExtensionID).Find(&extension).RecordNotFound() {
log.InfoWithFields("extension not found", log.Fields{
"id": projectExtension.Model.ID,
"release_extension_id": releaseExtension.Model.ID,
})
return fmt.Errorf("extension %s not found", projectExtension.ExtensionID)
}

if plugins.Type(extension.Type) == plugins.GetType("workflow") {
// check if the last release extension has the same
// ServicesSignature and SecretsSignature. If so,
// mark the action as completed before sending the event
lastReleaseExtension := model.ReleaseExtension{}
artifacts := []transistor.Artifact{}

eventAction := transistor.GetAction("create")
eventState := transistor.GetState("waiting")
eventStateMessage := ""
needsExtract := true

if !release.ForceRebuild && extension.Cacheable {
// query for the most recent complete release extension that has the same services, secrets and feature hash as this one
err = x.DB.Where("project_extension_id = ? and services_signature = ? and secrets_signature = ? and feature_hash = ? and state in (?)",
projectExtension.Model.ID, releaseExtension.ServicesSignature,
releaseExtension.SecretsSignature, releaseExtension.FeatureHash,
[]string{"complete"}).Order("created_at desc").First(&lastReleaseExtension).Error
if err != nil {
log.Error(err.Error())
} else {
eventAction = transistor.GetAction("status")
eventState = lastReleaseExtension.State
eventStateMessage = fmt.Sprintf("Using cache from previous release: %s", lastReleaseExtension.StateMessage)

err := json.Unmarshal(lastReleaseExtension.Artifacts.RawMessage, &artifacts)
if err != nil {
log.Error(err.Error())
return nil
}

needsExtract = false
}
}

if needsExtract {
artifacts, err = graphql_resolver.ExtractArtifacts(projectExtension, extension, x.DB)
if err != nil {
log.Error(err.Error())
return nil
}
}

payload := plugins.ReleaseExtension{
ID: releaseExtension.Model.ID.String(),
Release: payload,
}

ev := transistor.NewEvent(transistor.EventName(fmt.Sprintf("release:%s", extension.Key)), eventAction, payload)
ev.State = eventState
ev.StateMessage = eventStateMessage
ev.Artifacts = artifacts

releaseExtension.Started = time.Now()
x.DB.Save(&releaseExtension)

x.Events <- ev
}
}

```

Click here to show extra information the analyzer produced.

```
No path was found through the callgraph that could lead to a function which writes a pointer argument.

The following graphviz dot graph describes paths through the callgraph that could lead to a function which passes a pointer to third-party code:
digraph G {
"(Save, 1)" -> {}
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 06371150b7aaaf104d41907c6f432a795238bf3c