github-vet / github-vet/rangeloop-pointer-findings
codeamp/circuit: plugins/kubernetes/deployment.go; 27 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [codeamp/circuit](https://www.github.com/codeamp/circuit) at [plugins/kubernetes/deployment.go](https://github.com/codeamp/circuit/blob/06371150b7aaaf104d41907c6f432a795238bf3c/plugins/kubernetes/deployment.go#L1672-L1698)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.
> reference to rs is reassigned at line 1696
[Click here to see the code in its original context.](https://github.com/codeamp/circuit/blob/06371150b7aaaf104d41907c6f432a795238bf3c/plugins/kubernetes/deployment.go#L1672-L1698)
Click here to show the 27 line(s) of Go which triggered the analyzer.
```go
for _, rs := range replicaSets.Items {
annotations := rs.GetAnnotations()
rsRevision, err := strconv.ParseInt(annotations["deployment.kubernetes.io/revision"], 10, 64)
if err != nil {
log.Error(err.Error())
continue
}
// If we've found the replicaset that matches the current deployment
// based off of the revision, then stuff in the data describing
// this deployment: pod spec, replica count, labels, annotations
if rsRevision == targetRevision {
results[deployment.GetName()] = &DeploymentConfiguration{
Replicas: *deployment.Spec.Replicas,
PodTemplateSpec: rs.Spec.Template,
Labels: deployment.GetLabels(),
Annotations: deploymentAnnotations,
}
foundTarget = true
break
}
// If we've found a more recent rs, keep track of it here
if mostRecentReplicaSet.ObjectMeta.CreationTimestamp.Before(&rs.ObjectMeta.CreationTimestamp) {
mostRecentReplicaSet = &rs
}
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: 06371150b7aaaf104d41907c6f432a795238bf3c
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.