github-vet / github-vet/rangeloop-pointer-findings

wheelcomplex/fswatcher: fswatcher.go; 25 LoC

Open
#11,728 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [wheelcomplex/fswatcher](https://www.github.com/wheelcomplex/fswatcher) at [fswatcher.go](https://github.com/wheelcomplex/fswatcher/blob/fc15843ba6dfd2d1aefb9595f157dee32f708234/fswatcher.go#L660-L684)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.

> range-loop variable lazyPath used in defer or goroutine at line 667

[Click here to see the code in its original context.](https://github.com/wheelcomplex/fswatcher/blob/fc15843ba6dfd2d1aefb9595f157dee32f708234/fswatcher.go#L660-L684)

Click here to show the 25 line(s) of Go which triggered the analyzer.

```go
for lazyPath, _ := range lazyList {
delete(lazyList, lazyPath)
lazygw.Add(1)
subscan++
go func() {
//fmt.Printf("watchMgr, new lazyWatch %v || %v\n", lazyPath, rescann)
//self.Dump("befor lazyRWatch" + lazyPath)
if nw := self.lazyRWatch(lazyPath); nw > 0 {
fmt.Printf("watchMgr, new lazyWatch %v || %v\n", nw, lazyPath)
//self.Dump("after lazyRWatch" + lazyPath)
}
//fmt.Printf("watchMgr, end lazyWatch %v || %v\n", lazyPath, rescann)
lazygw.Done()
}()
//fmt.Printf("watchMgr, new lazyWatch %v end.\n", lazyPath)
if self.lazyAddStack.GetCacheSize() >= 2048 {
println("lazyRWatch abort for too many new events", self.lazyAddStack.GetCacheSize())
break
}
if subscan > 2 {
subscan = 0
// blocking
lazygw.Wait()
}
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: fc15843ba6dfd2d1aefb9595f157dee32f708234

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.