github-vet / github-vet/rangeloop-pointer-findings

maistra/istio: pilot/pkg/status/state.go; 6 LoC

Open
#11,723 0 comments 0 reactions 0 assignees View on GitHub
fresh tiny
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [maistra/istio](https://www.github.com/maistra/istio) at [pilot/pkg/status/state.go](https://github.com/maistra/istio/blob/e7fb8d5b3ef08aa161073ace01748f158f09690d/pilot/pkg/status/state.go#L257-L262)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to c is reassigned at line 259

[Click here to see the code in its original context.](https://github.com/maistra/istio/blob/e7fb8d5b3ef08aa161073ace01748f158f09690d/pilot/pkg/status/state.go#L257-L262)

Click here to show the 6 line(s) of Go which triggered the analyzer.

```go
for i, c := range currentStatus.Conditions {
if c.Type == Reconciled {
currentCondition = &c
conditionIndex = i
}
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: e7fb8d5b3ef08aa161073ace01748f158f09690d

Contributor guide

No contributing guide indexed for this repository

Research direction

Open pilot/pkg/status/state.go at lines 257-262 and inspect how currentCondition is used after the range loop. Decide whether taking a reference to c creates the reported range-variable problem, then leave the requested reaction classifying it as a bug, mitigated, or desirable behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.