github-vet / github-vet/rangeloop-pointer-findings
davecheney/benchjuju: src/github.com/juju/juju/provider/openstack/provider.go; 12 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [davecheney/benchjuju](https://www.github.com/davecheney/benchjuju) at [src/github.com/juju/juju/provider/openstack/provider.go](https://github.com/davecheney/benchjuju/blob/43fb99820e9158cabe9141573cf05c874352e988/src/github.com/juju/juju/provider/openstack/provider.go#L735-L746)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.
> reference to fip is reassigned at line 736
[Click here to see the code in its original context.](https://github.com/davecheney/benchjuju/blob/43fb99820e9158cabe9141573cf05c874352e988/src/github.com/juju/juju/provider/openstack/provider.go#L735-L746)
Click here to show the 12 line(s) of Go which triggered the analyzer.
```go
for _, fip := range fips {
newfip = &fip
if fip.InstanceId != nil && *fip.InstanceId != "" {
// unavailable, skip
newfip = nil
continue
} else {
logger.Debugf("found unassigned public ip: %v", newfip.IP)
// unassigned, we can use it
return newfip, nil
}
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: 43fb99820e9158cabe9141573cf05c874352e988
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.