github-vet / github-vet/rangeloop-pointer-findings
Perezonance/bnr-assignment: src/pkg/server/service.go; 18 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [Perezonance/bnr-assignment](https://www.github.com/Perezonance/bnr-assignment) at [src/pkg/server/service.go](https://github.com/Perezonance/bnr-assignment/blob/4819ccbb014302feb12ebdbffd4e5338ecb71bb8/src/pkg/server/service.go#L142-L159)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.
> range-loop variable i used in defer or goroutine at line 144
[Click here to see the code in its original context.](https://github.com/Perezonance/bnr-assignment/blob/4819ccbb014302feb12ebdbffd4e5338ecb71bb8/src/pkg/server/service.go#L142-L159)
Click here to show the 18 line(s) of Go which triggered the analyzer.
```go
for _, i := range ids {
go func(){
u, err := s.db.GetUser(i)
if err != nil {
util.ErrorLog("Failed to GetUser", err)
util.WriteRes(http.StatusInternalServerError, http.StatusText(http.StatusInternalServerError), w)
return
}
err = s.db.DeleteUser(u)
if err != nil {
util.ErrorLog("Failed to DeleteUser", err)
util.WriteRes(http.StatusInternalServerError, http.StatusText(http.StatusInternalServerError), w)
return
}
//TODO: There might be an issue with having many goroutines access this slice. May have to use a channel...
users = append(users, u)
}()
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: 4819ccbb014302feb12ebdbffd4e5338ecb71bb8
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.