github-vet / github-vet/rangeloop-pointer-findings

lyft/flytepropeller: pkg/apis/flyteworkflow/v1alpha1/zz_generated.deepcopy.go; 11 LoC

Open
#11,590 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [lyft/flytepropeller](https://www.github.com/lyft/flytepropeller) at [pkg/apis/flyteworkflow/v1alpha1/zz_generated.deepcopy.go](https://github.com/lyft/flytepropeller/blob/f2a4b79a3f4c596bb3dacf72e1834f3fd6ca4aee/pkg/apis/flyteworkflow/v1alpha1/zz_generated.deepcopy.go#L655-L665)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to val is reassigned at line 660

[Click here to see the code in its original context.](https://github.com/lyft/flytepropeller/blob/f2a4b79a3f4c596bb3dacf72e1834f3fd6ca4aee/pkg/apis/flyteworkflow/v1alpha1/zz_generated.deepcopy.go#L655-L665)

Click here to show the 11 line(s) of Go which triggered the analyzer.

```go
for key, val := range *in {
var outVal *NodeSpec
if val == nil {
(*out)[key] = nil
} else {
in, out := &val, &outVal
*out = new(NodeSpec)
(*in).DeepCopyInto(*out)
}
(*out)[key] = outVal
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: f2a4b79a3f4c596bb3dacf72e1834f3fd6ca4aee

Contributor guide

No contributing guide indexed for this repository

Research direction

Inspect pkg/apis/flyteworkflow/v1alpha1/zz_generated.deepcopy.go around lines 655-665 and review how the range variable is referenced and reassigned. Determine whether the analyzer finding is a bug, mitigated, or desirable behavior, then leave the corresponding reaction on the issue.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.