github-vet / github-vet/rangeloop-pointer-findings
facesea/banshee: alerter/alerter.go; 21 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [facesea/banshee](https://www.github.com/facesea/banshee) at [alerter/alerter.go](https://github.com/facesea/banshee/blob/299c84643e5067d1925f57f90c2b59f6add68ff8/alerter/alerter.go#L166-L186)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.
> reference to user was used in a composite literal at line 171
[Click here to see the code in its original context.](https://github.com/facesea/banshee/blob/299c84643e5067d1925f57f90c2b59f6add68ff8/alerter/alerter.go#L166-L186)
Click here to show the 21 line(s) of Go which triggered the analyzer.
```go
for _, user := range users {
d := &msg{
ID: eventID,
Project: proj,
Metric: metric,
User: &user,
Rule: rule,
}
// Exec
if len(al.cfg.Alerter.Command) == 0 {
log.Warn("alert command not configured")
continue
}
b, _ := json.Marshal(d)
cmd := exec.Command(al.cfg.Alerter.Command, string(b))
if err := cmd.Run(); err != nil {
log.Error("exec %s: %v", al.cfg.Alerter.Command, err)
continue
}
log.Info("send message to %s with %s ok", user.Name, metric.Name)
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: 299c84643e5067d1925f57f90c2b59f6add68ff8
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.