github-vet / github-vet/rangeloop-pointer-findings

fairfaxmedia/flywheel: aws.go; 28 LoC

Open
#11,501 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [fairfaxmedia/flywheel](https://www.github.com/fairfaxmedia/flywheel) at [aws.go](https://github.com/fairfaxmedia/flywheel/blob/7267f1a1ab937775f0560efd85c05e1473e5cb45/aws.go#L75-L102)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to groupName was used in a composite literal at line 80

[Click here to see the code in its original context.](https://github.com/fairfaxmedia/flywheel/blob/7267f1a1ab937775f0560efd85c05e1473e5cb45/aws.go#L75-L102)

Click here to show the 28 line(s) of Go which triggered the analyzer.

```go
for _, groupName := range fw.config.AutoScaling.Stop {
log.Printf("Starting autoscaling group %s", groupName)

resp, err := fw.autoscaling.DescribeAutoScalingGroups(
&autoscaling.DescribeAutoScalingGroupsInput{
AutoScalingGroupNames: []*string{&groupName},
},
)
if err != nil {
return err
}

group := resp.AutoScalingGroups[0]

instanceIds := []*string{}
for _, instance := range group.Instances {
instanceIds = append(instanceIds, instance.InstanceId)
}

_, err = fw.ec2.StartInstances(
&ec2.StartInstancesInput{
InstanceIds: instanceIds,
},
)
if err != nil {
return err
}
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 7267f1a1ab937775f0560efd85c05e1473e5cb45

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.