github-vet / github-vet/rangeloop-pointer-findings
EPICPaaS/yixinappsrv: perf/perf.go; 8 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [EPICPaaS/yixinappsrv](https://www.github.com/EPICPaaS/yixinappsrv) at [perf/perf.go](https://github.com/EPICPaaS/yixinappsrv/blob/419ab0eb45373c0c2fc32a35da8785c52bac59d1/perf/perf.go#L35-L42)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.
> range-loop variable addr used in defer or goroutine at line 37
[Click here to see the code in its original context.](https://github.com/EPICPaaS/yixinappsrv/blob/419ab0eb45373c0c2fc32a35da8785c52bac59d1/perf/perf.go#L35-L42)
Click here to show the 8 line(s) of Go which triggered the analyzer.
```go
for _, addr := range pprofBind {
go func() {
if err := http.ListenAndServe(addr, pprofServeMux); err != nil {
logger.Errorf("http.ListenAndServe(\"%s\", pprofServeMux) error(%v)", addr, err)
panic(err)
}
}()
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: 419ab0eb45373c0c2fc32a35da8785c52bac59d1
Contributor guide
No contributing guide indexed for this repository
Research direction
Inspect perf/perf.go at lines 35-42, focusing on the goroutine launched inside the range loop and how it uses addr. Decide whether the analyzer finding is a bug, mitigated, or desirable behavior, then leave the corresponding reaction on the issue.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 35/100